Export ostream formatters and streamed() from the module#4861
Merged
Conversation
vitaut
requested changes
Jul 22, 2026
vitaut
left a comment
vitaut
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR! Exporting makes sense but I think we should wrap the whole public API block in FMT_BEGIN_EXPORT / FMT_END_EXPORT instead of doing it one declaration by declaration.
Make basic_ostream_formatter, ostream_formatter and streamed() accessible to module users via FMT_BEGIN_EXPORT/FMT_BEGIN_EXPORT. Drop now unneeded FMT_EXPORT for print() and println().
avikivity
force-pushed
the
export-ostream
branch
from
July 23, 2026 09:25
5ea0e3a to
21d6c98
Compare
Contributor
Author
|
v2: use FMT_BEGIN_EXPORT, drop now-unneeded FMT_EXPORT |
vitaut
approved these changes
Jul 23, 2026
Contributor
|
Lint issue is preexisting - will fix it separately. |
Contributor
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make basic_ostream_formatter, ostream_formatter and streamed() accessible to module users.