magic_starter 0.0.1-alpha.20 - #94
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump and changelog date. Two files, matching #90's shape.
What ships
Exactly two commits since
0.0.1-alpha.19, both about one defect:MSPageHeader's inline mode is settable from the theme, so its two halves cannot drift apart.Nothing else is in
[Unreleased], so this release is the header fix and its paper, and nothing rides along.Why it is worth a release rather than waiting
inlineActionsdoes two things at once: it selectscontainerInlineClassName, and it gives the title rowflex-1 min-w-0instead ofsm:flex-1. The container class is a theme string and the flex behaviour was a widget argument, so a consumer could set the first and not the second, and that combination silently overflows.MSPageScaffolddoes not forward the argument at all, so a scaffold consumer could not reach the second half even knowing it existed.The consumer that hit it is depools, whose product screen reports
A RenderFlex overflowed by 40 pixels on the rightat 390 today. It cannot take the fix until this is on pub.dev: it pins^0.0.1-alpha.17, and the field does not exist inalpha.19.Not breaking
MSPageHeader.inlineActionsbecamebool?falling back to a theme field that defaults tofalse, which is the previous behaviour, and an explicit argument still wins. Every existing caller is unchanged.Verification
dart pub publish --dry-runclean apart from the two files this PR is about (they read as modified until it is committed) and the standingpubspec_overrides.yamlhints, which are the workspace's local sibling paths and are gitignored, so CI resolves the hosted versions instead.dart format --set-exit-if-changed .clean,dart analyzeclean, 1253 tests pass. The overflow is one of them: reverting the title-row half reportsA RenderFlex overflowed by 79 pixels on the right.After merge
git tag 0.0.1-alpha.20 && git push --tagsfirespublish.yml, which is the trigger this repo uses.One thing noticed and left alone
CLAUDE.md's banner still reads**Version:** 0.0.1-alpha.14, six releases behind. Previous release PRs did not touch it either, so it is clearly not part of this ritual, and correcting it inside a release PR would add review surface with no release value. Worth its own one-line PR.