Conversation
Replaces deprecated ProcessAdapter with ProcessListener. Reduces deprecated API usages by 33 in 2025.2 (future-proofing for when check is enabled). https://github.com/JetBrains/intellij-community/blob/master/platform/util/src/com/intellij/execution/process/ProcessAdapter.java
|
Cool! Here's a thought... |
|
I like the adapter pattern as well, but expectations are shifting under us here. This PR is almost free and moves our repo in a direction that will have it more accepted and green in the JB Marketplace. Lets chat on VC, I can completely see both sides of the argument here, lets defer to the larger team. |
I think that's debatable given our time talking about it 😄 -- but it's all good! It's more than worth the time since it's a nice way to frame a larger and more important question about evolving coding standards. My 2 cents is that while it may be free to add the boilerplate, we'll continue to pay the price in the ways we always have with unnecessary code (in the way of maintenance and understandability). I don't really see a shift here but I think it's an awesome conversation to have. Looking forward to it! |
Addresses deprecated `ProcessAdapter` references and avoids boilerplate by adding our own. Replaces #8670. See: #8764 --- - [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR. <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide]([https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Dart contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Java and Kotlin contributions should strive to follow Java and Kotlin best practices ([discussion](#8098)). </details>
Replaces deprecated ProcessAdapter with ProcessListener. Reduces deprecated API usages by 33 in 2025.2 (future-proofing for when check is enabled).
https://github.com/JetBrains/intellij-community/blob/master/platform/util/src/com/intellij/execution/process/ProcessAdapter.java