Skip to content

Fix ProcessAdapter deprecation warnings#8670

Open
jwren wants to merge 1 commit intoflutter:mainfrom
jwren:ver-01-process-listener
Open

Fix ProcessAdapter deprecation warnings#8670
jwren wants to merge 1 commit intoflutter:mainfrom
jwren:ver-01-process-listener

Conversation

@jwren
Copy link
Member

@jwren jwren commented Jan 2, 2026

Replaces deprecated ProcessAdapter with ProcessListener. Reduces deprecated API usages by 33 in 2025.2 (future-proofing for when check is enabled).

https://github.com/JetBrains/intellij-community/blob/master/platform/util/src/com/intellij/execution/process/ProcessAdapter.java

Replaces deprecated ProcessAdapter with ProcessListener.
Reduces deprecated API usages by 33 in 2025.2 (future-proofing for when check is enabled).

https://github.com/JetBrains/intellij-community/blob/master/platform/util/src/com/intellij/execution/process/ProcessAdapter.java
@jwren jwren requested review from helin24 and pq January 2, 2026 22:59
@jwren jwren added the 🤖 AI-assisted For PRs with significant code generated by AI label Jan 2, 2026
@pq
Copy link
Collaborator

pq commented Jan 9, 2026

Cool!

Here's a thought... ProcessAdapter was nice in that it avoided a bunch of boilerplate which this PR adds in. How about introducing our own ProcessAdapter so we can reap the benefits (without depending on deprecated API)? Maybe in io.flutter.utils?

@jwren
Copy link
Member Author

jwren commented Jan 9, 2026

I like the adapter pattern as well, but expectations are shifting under us here. This PR is almost free and moves our repo in a direction that will have it more accepted and green in the JB Marketplace.

Lets chat on VC, I can completely see both sides of the argument here, lets defer to the larger team.

@pq
Copy link
Collaborator

pq commented Jan 9, 2026

This PR is almost free

I think that's debatable given our time talking about it 😄 -- but it's all good! It's more than worth the time since it's a nice way to frame a larger and more important question about evolving coding standards.

My 2 cents is that while it may be free to add the boilerplate, we'll continue to pay the price in the ways we always have with unnecessary code (in the way of maintenance and understandability). I don't really see a shift here but I think it's an awesome conversation to have. Looking forward to it!

pq added a commit that referenced this pull request Feb 8, 2026
Addresses deprecated `ProcessAdapter` references and avoids boilerplate
by adding our own.

Replaces #8670.

See: #8764

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide]([https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Dart contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Java and Kotlin contributions should strive to follow Java and Kotlin
best practices
([discussion](#8098)).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖 AI-assisted For PRs with significant code generated by AI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments