Skip to content

[tool] Update skills_lint to published version ^0.5.1 #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reidbaker-agent wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[tool] Update skills_lint to published version ^0.5.1 #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions tool/generator/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,6 @@ dev_dependencies:
build_verify: ^3.1.0
coverage: ^1.15.0
lints: ^6.0.0
skills_lint:
git:
url: https://github.com/google/skills_lint.dart.git
path: packages/skills_lint
ref: e6e695e1550f81342fe5acd4dbe65040b5aa44c3
skills_lint: ^0.5.1
test: ^1.25.6

6 changes: 6 additions & 0 deletions tool/generator/test/custom_skill_rules/last_modified_rule.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@ class LastModifiedRule extends SkillRule {
return errors;
}

final skillName = yaml['name'];
if (skillName is String && skillName.startsWith('dart-')) {
// Dart skills are synced from dart-lang/skills and do not track generator metadata.
return errors;
}

final Object? metadata = yaml[_metadataKey];
if (metadata is! Map || !metadata.containsKey(_lastModifiedKey)) {
errors.add(
Expand Down
Loading