Repository navigation
zstd compression: stop using the streaming feature #5111
Description
Activity
Note for when moving off the streaming feature:
If the plan is to compress each segment with one-shot
Zstd.compressand concatenate
the results, note that the decompress side then has to handle concatenated zstd frames.
On current zstd-ruby this matters:Zstd.decompress(one-shot) returns only the first frame and silently drops the rest.Zstd::StreamingDecompress#decompressdecodes all frames correctly.
There's an open PR to make the one-shot
Zstd.decompresshandle concatenated frames as well: SpringMT/zstd-ruby#139.
Until that ships, the safe read path isStreamingDecompress#decompress.
Is your feature request related to a problem? Please describe.
The streaming feature (
Zstd::StreamWriterandZstd::StreamReader) of zstd-ruby is experimental.Actually, there was a bug.
Although the critical bug has been resolved, some strange behavior is still being reported.
We considered that we may not need to use the streaming feature.
It would be better to stop using the streaming feature if it is unnecessary.
Describe the solution you'd like
#5094 (comment)
Describe alternatives you've considered
None.
Additional context
No response