This repository was archived by the owner on Dec 19, 2024. It is now read-only.
Open
Conversation
Brianzchen
changed the title
Brianzchen
changed the title
Brianzchen
changed the title
Author
|
Ran compiler and tested on local vscode |
Closed
Contributor
|
thanks for this! I had to push through an update to 0.183.0 in 8e38e1e, but this PR has a lot of better fixes so I'd like to leave this open and rebase it when I get some time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update flow from 0.107.0 to 0.146.0 to establish a good base to continue further development on the project.
Also disable linting rules in particular areas so that
yarn eslint .doesn't throw errors and we have a cleaner projectThe major goal here is to clean up all flow errors without changing the underlying logic as I cannot be sure what the overall impact would be and also there are minimal tests in general
Closes #410