Repository navigation
fix(windows): polish settings and tray UI - #123
Open
SantanuDatta wants to merge 4 commits into
Open
SantanuDatta wants to merge 4 commits into
SantanuDatta wants to merge 4 commits into
Conversation
Improve alignment and spacing, service filter presentation, title-bar theme contrast, About logo loading, and action menu placement and readability. Refs flock-php#122
|
Thanks for the PR, @SantanuDatta! Flock takes pull requests only for issues a maintainer has approved, so this one is closed. Edit this pull request's description to reference an approved issue, then save it to reopen automatically. See CONTRIBUTING.md. |
onairmarc
approved these changes
Nov 7, 2026
Scope the red button palette to the destructive action while preserving Cancel as the default. Add a confirmation screenshot check for both themes.
auto-merge was automatically disabled
November 8, 2026 03:58
Head branch was pushed to by a user without write access
SantanuDatta
force-pushed
the
fix/windows-ui-polish
branch
from
November 8, 2026 04:01
aa7e444 to
93d538f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #122
What and why
I noticed a few things looking out of place while using Flock on Windows. This PR fixes the alignment of the tray switches and settings rows, adds some breathing room around the headings, and separates the service cards so they no longer touch the scrollbar.
The All / Installed selector now fits the service list, with All first and a clearer selected state. I also removed the extra space above the title bar, fixed the window buttons in light mode, and restored the About logo.
The PHP, FrankenPHP, and Node dropdowns now stay inside the window. Their backgrounds are solid so the content underneath no longer shows through.
These are UI changes only, with the existing filtering behavior kept as it is.
How I tested it
The Release build passed with no warnings or errors, and all 393 tests passed. I checked both themes, the service filters, dropdowns, and keyboard navigation. I also checked the filter labels with enlarged text in the screenshot runner.
Before and after
Note: I've kept these in one PR because they are small, related visual fixes. Reviewing them together should be easier than opening a separate PR for each spacing or alignment change.