fix: stabilize markdown table search and selection#137
Merged
Conversation
c556cfe to
c0236da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setDocument(), and editor teardown without stale-range writes or data loss.\|delimiters, rich inline Markdown, repeated link labels/URLs, multi-backtick inline code, and full-document regexp context.Behavior note
setDocument()anddestroy()now flush a pending table-cell edit before replacement/teardown. A non-silent pending edit is emitted throughonChangebefore the lifecycle operation completes.Verification
pnpm test→ pass (537 tests)pnpm typecheck→ passpnpm build→ passpnpm build:electron-demo→ passpnpm exec vitest run packages/core/test/editor.test.ts packages/core/test/live-preview.test.ts packages/plugin-search/test/plugin-search.test.ts→ pass (159 tests)git diff --check→ passCmd+Fselected the rendered table match; IME intermediate text stayed out of Markdown until commit.Compliance