Fix/clear orphaned views#37
Merged
Merged
Conversation
flipbit
commented
Jun 22, 2026
flipbit
commented
Owner
- Fix an issue where notes are manually added to an image are not detected by the programatic API
- Bump version to 2.0.0-beta.4
commitSave() in AnnotateEdit created a new AnnotateView but never assigned it to note.view, so destroyViews() could not clean it up. Additionally, destroyViews() only iterated the current notes array, leaving orphans when the array was replaced externally before load(). Fixes both by assigning note.view after creation and clearing the viewOverlay as a safety net in destroyViews().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.