Conversation
|
Looking good! 
I'll poke around a little bit and will let you know if I encounter any issues. Edit: |
|
Just love it when OpenSource stuff outperforms proprietary software. 
I'd propose to rename "Battery output energy". This is misleading. It should be "total output energy". If you bypass the battery and directly feed the grid it can be much higher than battery input energy, which is weird ;-) |
Renamed output_energy Sensor to account for energy bypassing the battery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I might also add support for the Solarbank 3 in this PR or I might do that later.
This is using the latest SolixBLE with the changes from this PR which adds propper support for devices like the solarbank which was raised under this issue.
This branch was created from the Anker prime branch which I intend to merge first so not all of the changes shown are from this branch/PR.