builder-module: Record licence files in licences directory as well#706
Open
builder-module: Record licence files in licences directory as well#706
Conversation
The licences directory is a common convention across Qt and KDE projects. See examples [1], [2], [3]. The files inside that directory usually use the licence id as their filename. Listing them individually inside licence-files key is annoying but without anything no licence information is recorded for these projects. So when collecting the default license files, also collect files inside the licences directory. [1]: https://github.com/qt/qtbase/tree/2d790125429123aec4fb3dbee8335732f2d122eb/LICENSES [2]: https://github.com/qt/qtwebengine/tree/cf5db2b9242facf4797a7779ae50916326f75d0b/LICENSES [3]: https://invent.kde.org/system/dolphin/-/tree/02165defeeeb529a566c8cc00f30e7a5c8c11185/LICENSES
Otherwise modifications to license-files would not invalidate the module cache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The licences directory is a common convention across Qt and KDE
projects. See examples 1, 2, 3. The files inside that directory
usually use the licence id as their filename. Listing them individually
inside licence-files key is annoying but without anything no licence
information is recorded for these projects. So when collecting the
default license files, also collect files inside the licences directory.