fix: unblock Thor validation (vocab-ce API, sageattention2 gate, fp8-cross-attention docs) - #8
Open
shideqin wants to merge 3 commits into
Open
Conversation
The README/CARD document vocab_ce_loss as the public training API but the package only exposed vocab_ce. Add the documented alias (delegating to vocab_ce) and re-run the installed smoke/full suites (2/2 pass).
The test gate required major>=12, rejecting Thor (sm_110, major 11) even though all six kernels pass on-device. Accept the full Blackwell family (sm_100/103/110/120); the widened gate passes 9/9 full rows on Thor (fp8v rows cos>=0.9992).
…validation Built for sm_110a with CUTLASS 4.4 (the declared cutlass_4_4 dependency; 4.5.x moved SM100_MMA_F8F6F4_SS to a class template and breaks csrc/fmha77) and closed the installed-artifact gate on Thor: 9/9 rows plus rejection, CUDA Graph replay, and torch.compile pass; production B1,Sq786,Sk7984 row cos=0.999786.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small changes that unblock the on-device Thor validation of previously green packages:
vocab_ce_losspublic API (README/CARD list it but the package only exposedvocab_ce). Installed smoke/full 2/2 pass.major>=12, rejecting Thor sm_110) to the full Blackwell family. With the gate open, 9/9 full rows pass on Thor (fp8v cos>=0.9992).B1,Sq786,Sk7984cos=0.999786).