feat(install-skills): add --agent parameter to select the agent for which to install them#8
Open
bercianor wants to merge 1 commit into
Open
feat(install-skills): add --agent parameter to select the agent for which to install them#8bercianor wants to merge 1 commit into
bercianor wants to merge 1 commit into
Conversation
…hich to install them
dieppa
requested changes
Jun 3, 2026
|
|
||
| @Option(names = {"-a", "--agent"}, | ||
| description = "Target AI assistant: agents, claude, or all (default: agents)", | ||
| defaultValue = "agents") |
Member
There was a problem hiding this comment.
I don't like agents as a value. I believe we have mixed two concepts: the agent(claude, codex, etc) and the target directory where the skill will be installed.
if the parameter was called --target, I would see the options agents and claude, but the parameter is the agent. And it's right the way it is, because we don't know how the agents will evolve, they may add another difference in the structure.
So, my suggestion is to remove the agents value. I see two options. (A) default value is null. No vaue means default installation. (B) list the agents we support.
I would definitely go with (A)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.