docs: refine FEP template Packaging and Test Plan sections#52
Open
Al2O3Al2O3 wants to merge 1 commit into
Open
docs: refine FEP template Packaging and Test Plan sections#52Al2O3Al2O3 wants to merge 1 commit into
Al2O3Al2O3 wants to merge 1 commit into
Conversation
Al2O3Al2O3
commented
Jul 7, 2026
Contributor
- Packaging: focus on build/packaging only (not install); add supported vendors field; center on whether the feature can ship as a .whl, with build steps or a prebuilt wheel when yes, and build-from-source when no
- Test Plan: drop image/install/setup steps; keep test commands and expected results, scoped to the new features in this release
- Packaging: focus on build/packaging only (not install); add supported vendors field; center on whether the feature can ship as a .whl, with build steps or a prebuilt wheel when yes, and build-from-source when no - Test Plan: drop image/install/setup steps; keep test commands and expected results, scoped to the new features in this release Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
gcw_AUYCkC0h seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
wbavon
approved these changes
Jul 9, 2026
wbavon
left a comment
Collaborator
There was a problem hiding this comment.
LGTM — 方向正确,关注点分离后模板更清晰。
几点小建议供后续迭代参考(不阻塞合并):
- Test Plan 可考虑加一行可选的 Prerequisites/Environment 字段,避免验证者不知如何搭建环境
- Packaging 的决策树可以稍微泛化,覆盖 Docker/system package 等非-wheel 场景
- 注释中
python -m build和pip wheel二选一即可,减少新手困惑
注意 CLA 状态需要解决后才能合并。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.