fix: resolve empty performance data in summary.json for dual-key oper…#5
Merged
Conversation
…ators When benchmark output contains two top-level keys (new operator name + legacy CUTENSOR_OP_* identifier), parse_perf_data() was only reading the primary key. For contraction/sparse operators the primary key had 'result' but no 'details', while the legacy key held the actual benchmark numbers. The function also returned early on failed/skipped results without attempting to populate benchmark data from sibling keys. - Scan sibling keys for details when the primary key has none - Still populate bench data on failed/skipped results so summary.json is never empty - Fixes BlockSparseContraction, Contraction, ContractionTrinary, ElementwiseTrinary showing data=EMPTY in summary.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ators
When benchmark output contains two top-level keys (new operator name