fix(deps): pin Flask/Werkzeug and add PasteDeploy so datapusher boots#29
Merged
Merged
Conversation
ckanserviceprovider==1.2.0 leaves Flask unpinned, so it resolved to Flask 3.x + Flask-Login 0.6.0 — incompatible (Flask-Login imports flask._request_ctx_stack, removed in Flask 2.3), so the uWSGI app failed to load. Also '--ini-paste' needs PasteDeploy, which wasn't installed. Pin Flask==2.1.3 + Werkzeug==2.1.2 (compatible with the bundled Flask-Login) and add PasteDeploy.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Datapusher fails to boot on the current stack:
ckanserviceprovider==1.2.0leaves Flask unpinned, so pip resolves Flask 3.x + Flask-Login 0.6.0, which are incompatible — Flask-Login importsflask._request_ctx_stack, removed in Flask 2.3 — so the uWSGI app fails to load (ImportError). Separately, the uWSGI--ini-pasteentrypoint needsPasteDeploy, which wasn't installed.Change
Pin a compatible Flask stack and add the missing build dep in
requirements.txt:Flask==2.1.3(still exposes_request_ctx_stack, so Flask-Login 0.6.0 works)Werkzeug==2.1.2(matching)PasteDeploy(foruwsgi --ini-paste)Verification
With these pins the datapusher container boots cleanly (
WSGI app 0 ... ready, workers spawned, no import errors) and responds to CKAN — verified on the ADR deploy: resource→datastore pushes complete after this fix.