feat: mint share tokens in the same hex style as note ids#320
Merged
Conversation
Share links now read like note links (/p/<32-hex> vs /note/<32-hex>) instead of standing out as 22-char base64url. Entropy is unchanged at 128 bits, and existing tokens keep resolving since lookups are exact string matches. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
newShareToken()now returns 32 lowercase hex chars (randomBytes(16).toString("hex")) instead of 22-char base64url, so/p/<token>share links look like/note/<id>linksTest plan
npm test— 125/125npx tsc --noEmitclean🤖 Generated with Claude Code