feat: animate the note-row options menu open and close#319
Merged
Conversation
The kebab menu snapped in and out of existence. Pop it from its anchor corner on open and slip it away on close, keeping it mounted through the exit via a small presence hook. Follows the reduced-motion opt-out the New-button flourish established. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useMenuPresencehook keeps the menu mounted through the exit animation;pointer-events: noneguards the closing state, andprefers-reduced-motiondisables both keyframes, following the New-button flourish's pattern.screenshots/pr/menu-pop.webm.Test plan
npm test— 125/125;npm run buildclean🤖 Generated with Claude Code