Remove fpsdk_ros1 and fpsdk_ros2 packages (move to fpsdk::common::ros[12]) - #215
Merged
Conversation
flipflip8952
force-pushed
the
derossify
branch
5 times, most recently
from
August 20, 2026 20:09
1b1f889 to
0bb2c95
Compare
…s, move fpsdk_ros[12] stuff to fpsdk_common/ros[12], remove fpsdk_ros[12] and examples
flipflip8952
force-pushed
the
derossify
branch
from
August 20, 2026 20:18
0bb2c95 to
484018c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor ROS1 BagWriter to fpsdk_common and add the necessary "rosnoros" dependencies
This allows us to write ROS1 .bag files anywhere, no ROS1 is needed at all (of course, it also works with ROS1).
Move fpsdk::ros[12] (fpsdk_ros[12]/...) stuf to fpsdk::common::ros[12] (fpsdk_common/) . Remove useless ros[12] example nodes (fixposition_driver is the better example).
Cleanup FPSDK_USE_ROS1 and FPSDK_USE_ROS2 pre-processor defines to be always defined with value 0 (disabled) or 1 (enabled), like all the other FPSDK_USE_... defines.
Migration for existing apps that use fpsdk_ros1 or fpsdk_ros2:
fpsdk_ros1respectivelyfpsdk_ros2dependency#include <fpsdk_ros1/*.hpp>to#include <fpsdk_common/ros1.hpp>and use namespacefpsdk::common::ros1instead offpsdk::ros1::*#ifdef FPSDK_USE_ROS1and#if defined(FPSDK_USE_ROS1)to#if FPSDK_USE_ROS1