Skip to content

Resolve final review blockers#96

Open
fitchmultz wants to merge 4 commits into
mainfrom
fix/final-review-blockers
Open

Resolve final review blockers#96
fitchmultz wants to merge 4 commits into
mainfrom
fix/final-review-blockers

Conversation

@fitchmultz
Copy link
Copy Markdown
Owner

@fitchmultz fitchmultz commented May 27, 2026

Summary

Addresses the withheld approval review for v0.1.20..HEAD.

  • Splits provider turn data into narrow sendRequest, finalizeInputs, and terminalResources; send now returns only send-owned facts.
  • Moves transcript message-offset lookup out of finalize internals into a send-layer helper.
  • Centralizes terminal event ownership in CursorRunFinalizer, including atomic fallback handling when direct terminal emission fails before pushing a terminal event.
  • Derives transcript display spec keys and replay summaries from the canonical tool registry instead of keeping duplicate summary policy in transcript specs.
  • Removes stale transcript summarize* replay helpers.
  • Fixes cursor-sdk-output-filter.d.mts to match runtime string patterns and adds export-map checks for every published .d.mts surface.
  • Validates debug-provider-events capture summaries before returning required declaration fields.
  • Splits the kitchen-sink test/helpers/pi-harness.ts into event, context, model, tool, registration, and type fixture modules while preserving the public helper barrel.
  • Keeps prior fixes for replay detail separation, smoke timeout status capture, package declaration shipping, duplicate classifier removal, and behavior-level MCP timeout tests.

Validation

  • npm run typecheck
  • npm test — 69 files / 585 tests
  • git diff --check
  • npm pack --dry-run — includes all shipped declaration-backed .mjs declarations
  • PI_LIVE_TIMEOUT=240 npm run smoke:isolated — basic provider, native replay, and plan-strip replay passed with clean replay-error scans
  • Thermo-nuclear review — ZERO FINDINGS

fitchmultz and others added 4 commits May 26, 2026 19:59
Split replay operation labels from canonical source names, dedupe replay builders via shared helpers, and scrub API keys from env and argv in maintainer script failure paths.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant