Resolve final review blockers#96
Open
fitchmultz wants to merge 4 commits into
Open
Conversation
Split replay operation labels from canonical source names, dedupe replay builders via shared helpers, and scrub API keys from env and argv in maintainer script failure paths. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the withheld approval review for
v0.1.20..HEAD.sendRequest,finalizeInputs, andterminalResources; send now returns only send-owned facts.CursorRunFinalizer, including atomic fallback handling when direct terminal emission fails before pushing a terminal event.summarize*replay helpers.cursor-sdk-output-filter.d.mtsto match runtime string patterns and adds export-map checks for every published.d.mtssurface.test/helpers/pi-harness.tsinto event, context, model, tool, registration, and type fixture modules while preserving the public helper barrel.Validation
npm run typechecknpm test— 69 files / 585 testsgit diff --checknpm pack --dry-run— includes all shipped declaration-backed.mjsdeclarationsPI_LIVE_TIMEOUT=240 npm run smoke:isolated— basic provider, native replay, and plan-strip replay passed with clean replay-error scans