Wire preAlert sound to Distracted Driver volume control - #82
Draft
Filaipus wants to merge 1 commit into
Draft
Conversation
The driver monitoring sound refactor introduced AudibleAlert.preAlert for the driverDistracted1 pre-warning, but it was never added to the alert volume controller's volume_map. Unmapped sounds fall through to the 1.01 auto-volume sentinel, so setting Distracted Driver volume to Muted silenced promptDistracted but the pre-warning kept playing at auto volume. preAlert is only used by driverDistracted1, so it follows PromptDistractedVolume like the rest of the distraction alert chain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The driver monitoring sound refactor introduced
AudibleAlert.preAlertfor thedriverDistracted1pre-warning (the black "Pay Attention" alert), but it was never added to soundd'svolume_map. Unmapped sounds fall through to the1.01auto-volume sentinel, so with the Alert Volume Controller enabled, setting Distracted Driver volume to Muted silencedpromptDistracted(the orange warning) while the pre-warning kept playing at auto volume.Fix
Map
AudibleAlert.preAlerttoPromptDistractedVolume.preAlertis only used bydriverDistracted1, so it follows the same volume control as the rest of the distraction alert chain (the redwarningImmediatestays on its own Immediate Warning control).