FDS Source: Remove PUBLIC attribute for subroutine#16029
Merged
mcgratta merged 1 commit intofiremodels:masterfrom Mar 9, 2026
Merged
FDS Source: Remove PUBLIC attribute for subroutine#16029mcgratta merged 1 commit intofiremodels:masterfrom
mcgratta merged 1 commit intofiremodels:masterfrom
Conversation
Contributor
|
Thanks for catching that. I made some recent changes to HVAC initialization and that routine is no longer externally called. |
Contributor
|
When I was fixing that bug where changed init I did get a segfault in a deallocation which led me to simplify/streamline some of the allocations. You may be seeing something similar. |
Contributor
Author
|
I'm going to run the problem case with and without |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FYI, I am debugging a case that seg faults in an HVAC routine when compiled with
-O2 -ipoand not with-O1. I am eliminating a possible source of confusion for the inter-procedural optimization. Probably a long-shot, but there is no need to assignPUBLICto a subroutine called from within the module.