[BHP1-1368] Refactor to use Table Entity Form in All Views

[Kcheung42]

Purpose

Related Issues

Closes BHP1-1368

Submission Checklist

• Included Jira issue in the PR title (e.g. BHP1-### <title>)
• Code passes linter rules (clj-kondo --lint components/**/src bases/**/src projects/**/src)
• Feature(s) work when compiled (clojure -M:compile-cljs)

Testing

There's quite a bit to views to test but there are two patterns to check

1. A simple table entity form (i.e. Modules, variables, tools, etc..) where it does not trigger a secondary table
2. A table entity form that triggers a second set of tables (i.e. Variable Domains, Lists, Tags, Units)

Testing Simple (Variables)

1. Ensure all entities show as expected
2. Ensure you can edit any selection
3. Ensure you can add an entry

Testing Slightly less Simple (Variable Domains)

1. Ensure when selecting a domain-set to edit a second table appears for the domains
2. Ensure you can edit domain-sets and domains
3. Ensure when changing a domain set to edit, the corresponding table also changes.

Screenshots

[rjsheperd]

@Kcheung42 This is a ton of work to simplify this, so kudos to you on taking this on!

I noticed a few things when running through the app:

1. After clicking "Update" within the "Entity Form", the form does not close. Can you add a "Cancel" button inside of the form that warns the user that any updates will be lost, and then closes the form?

2. No longer able to update the following "nested" entities:

• List Options inside of Lists
• Tags inside of Tag Sets
• Units inside of Domains
• Domains inside of Domain Sets

I would suggest reverting these back, for now, and opening up a ticket to address these separately.

Lists / List Options

Tag Sets / Tags

Domains / Units

Domain Sets / Domains

3. Inside of the "Variable" view, it looks like the "Add Entry" button is still appearing despite it not doing anything. Maybe it could be removed when the add-entry-fn is nil?

4. Can you update the "Subtools" Table / Entity Form to also use this component? Seems like it is there but it's not quite hooked up:

[Kcheung42]

Ah thanks for catching this, I think I pushed an update that added a check for an on-select fn to be passed into the table-entity-form but forgot to bind it in the params, easy fix here. I've also updated subtools to use the new component

[Kcheung42]

Inside of the "Variable" view, it looks like the "Add Entry" button is still appearing despite it not doing anything. Maybe it could be removed when the add-entry-fn is nil?

ah missed this one, working on this now

[Kcheung42]

updated.

[rjsheperd]

Last few things:

1. Please consider Use cljfmt on Behave CMS files #191 to format the files (uses your .cljfmt.edn)
2. Consider making it so after clicking "Update" after editing an entity, the form disappears (similar to when adding an entity)

[Kcheung42]

updated. New keys added to the table entity form :translation-config meant to be used by list views to automatically create a translation entry based on the name of the entity, (see tags page) :translations-attr a vector of label name and translation key attr that will display translations (see list options, surface fuel models)

[rjsheperd]

Looks great! Approved 👍