Skip to content

Header Updated #26

Open
chocos10 wants to merge 9 commits into
firefox-addons:gh-pagesfrom
chocos10:gh-pages
Open

Header Updated #26
chocos10 wants to merge 9 commits into
firefox-addons:gh-pagesfrom
chocos10:gh-pages

Conversation

@chocos10

@chocos10 chocos10 commented Oct 21, 2017

Copy link
Copy Markdown

referenced to #14

@tsl143

tsl143 commented Oct 28, 2017

Copy link
Copy Markdown
Member

@chocos10 , thanks for taking this.
This looks good, but breaks in responsive design.
screen shot 2017-10-28 at 10 35 48 am

Comment thread style.css Outdated

#logo img {
height: 100px;
float: left;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try flex-box, instead of floats. This will help you deal with mobile layout too.

Comment thread style.css Outdated
margin-top: -60px;
}
h1{
font-family: 'Concert One', cursive;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stick to zilla fonts as mentioned in style guide lines (mozilla.ninja)

Comment thread style.css
}

#logo img {
height: 100px;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image included is 48px and is stretched to 100px so it looks blurred.

@chocos10

Copy link
Copy Markdown
Author

@tsl143 will change this thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants