Skip to content

fix(helm): validate and honor deployment configuration (FB-4384) - #112

Open
simonzelenskifbio wants to merge 7 commits into
FB-4383-request-safetyfrom
FB-4384-configuration-correctness
Open

simonzelenskifbio wants to merge 7 commits into
FB-4383-request-safetyfrom
FB-4384-configuration-correctness

Conversation

@simonzelenskifbio

@simonzelenskifbio simonzelenskifbio commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Background

FB-4384: supported-looking values could produce mismatched database Secret references, ignore a requested storage class, or change metadata configuration without a restart.

Summary

Use one credential Secret resolver for both bundled PostgreSQL and metadata; honor explicit/empty storage classes; hash full metadata configuration and external credential versions; expose generic Metadata Service Deployment annotations for optional external reload controllers and document explicit restarts after database credential changes. Reject duplicate identities, overlong generated names, and chart-owned environment/volume/mount/annotation collisions. Online upgrades reject changes to existing instance identity. Extend PostgreSQL's Helm hook to authenticate and execute SELECT 1.

Stack 2/6 for FB-4382, based on #111. No operator changes. Existing PVC claim-template changes still require a deliberate migration, and offline renderers must preserve installation identity themselves.

Test Plan

  • Full validation with Helm 3.16.3 and render regressions: passed.
  • Generated values documentation, docs navigation checks, and diff checks: passed.
  • Local kind upgrade with a 4Gi engine test overlay: deployment, SELECT 1, and managed-table create/insert/read/drop passed. Full Helm hook results are recorded in the stack validation update.

Stack navigation: #111 → #112 → #113 → #114 → #117 → #120. Parent: FB-4382. Merge in this order. Signing-key rotation documentation is in #120 (FB-4481).

Revision validation: workload annotations remain on the Deployment resource and do not change its pod template. Non-string annotation values are rejected. The final stack passes 20 render regressions and full chart validation; a manual Metadata Service restart and all SQL/Helm hooks passed on local kind.


Note

Medium Risk
Changes install/upgrade behavior (fail-fast validation, metadata rollout triggers, unified DB secret wiring, instance ID guard); misconfigured upgrades or credential rotation still need coordinated DB + restart steps documented in the PR.

Overview
Adds render-time validation (_validation.tpl via validate.yaml) so invalid values fail helm template/install instead of producing broken manifests: duplicate engines or signing key IDs, DNS-length name limits, collisions with chart-owned env/volumes/mounts/paths, reserved rollout annotations, missing postgresql.host when external, and blocking customEngineConfig.instance.id changes on online upgrade.

PostgreSQL credentials now resolve through fbinstance.postgresSecretName so postgresql.credentials.existingSecret applies to bundled PostgreSQL and the Metadata Service (no chart Secret when set). Metadata rollout checksums hash the full rendered ConfigMap; with an external credential Secret, a resourceVersion checksum triggers restarts on credential rotation. New metadata.annotations (Deployment-only, schema-validated strings) supports optional secret-reload controllers without touching the pod template.

Engine PVCs honor storageClassName when set, including an explicit empty string. The bundled Postgres Helm test uses the pinned image, Secret-backed env, and SELECT 1 auth check. Docs/README/values comments cover render safeguards, credential rotation restarts, and bundled existingSecret behavior.

Reviewed by Cursor Bugbot for commit ff94bc4. Bugbot is set up for automated code reviews on this repo. Configure here.

Resolve PostgreSQL credentials consistently, render explicit storage classes, and track all metadata config inputs. Reject invalid identities and reserved-field collisions before Kubernetes admission.
@fireboltdb-docs-integration

fireboltdb-docs-integration Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Mintlify docs preview

Docs were aggregated into the Firebolt documentation site.

Status Preview Updated (UTC)
🟢 Ready View Preview Oct 02, 2026, 9:34 AM

Mintlify may take a few minutes to finish building. This comment updates on each sync while the source PR is open.

@simonzelenskifbio
simonzelenskifbio marked this pull request as ready for review October 1, 2026 15:33
cursor[bot]
cursor Bot previously approved these changes Oct 1, 2026

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Risk: medium. Approved: Cursor Bugbot and Cursor Security Agent completed successfully with no findings that need human review. Configuration and credential-wiring changes stay within the medium-risk threshold.

Open in Web View Automation 

Sent by Cursor Approval Agent: Infra Reviewer

cursor[bot]
cursor Bot previously approved these changes Oct 2, 2026

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Risk: medium. Approved: Cursor Bugbot completed successfully with no findings that need human review. Cursor Security Agent was not running; configuration and credential-wiring changes stay within the medium-risk threshold.

Open in Web View Automation 

Sent by Cursor Approval Agent: Infra Reviewer

@cursor
cursor Bot requested review from fstr and gm42 October 2, 2026 09:38
@cursor
cursor Bot dismissed their stale review October 2, 2026 09:38

Risk: medium. Dismissed the prior approval because Cursor Bugbot was still pending after 8 minutes, so the required automated-review signal is incomplete. Reviewers fstr and gm42 were assigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants