Repository navigation
fix(helm): validate and honor deployment configuration (FB-4384) - #112
Open
simonzelenskifbio wants to merge 7 commits into
Open
simonzelenskifbio wants to merge 7 commits into
simonzelenskifbio wants to merge 7 commits into
Conversation
Resolve PostgreSQL credentials consistently, render explicit storage classes, and track all metadata config inputs. Reject invalid identities and reserved-field collisions before Kubernetes admission.
Mintlify docs previewDocs were aggregated into the Firebolt documentation site.
Mintlify may take a few minutes to finish building. This comment updates on each sync while the source PR is open. |
This was referenced Sep 29, 2026
simonzelenskifbio
marked this pull request as ready for review
October 1, 2026 15:33
cursor
Bot
dismissed
their stale review
October 2, 2026 09:38
Risk: medium. Dismissed the prior approval because Cursor Bugbot was still pending after 8 minutes, so the required automated-review signal is incomplete. Reviewers fstr and gm42 were assigned.
fstr
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Background
FB-4384: supported-looking values could produce mismatched database Secret references, ignore a requested storage class, or change metadata configuration without a restart.
Summary
Use one credential Secret resolver for both bundled PostgreSQL and metadata; honor explicit/empty storage classes; hash full metadata configuration and external credential versions; expose generic Metadata Service Deployment annotations for optional external reload controllers and document explicit restarts after database credential changes. Reject duplicate identities, overlong generated names, and chart-owned environment/volume/mount/annotation collisions. Online upgrades reject changes to existing instance identity. Extend PostgreSQL's Helm hook to authenticate and execute SELECT 1.
Stack 2/6 for FB-4382, based on #111. No operator changes. Existing PVC claim-template changes still require a deliberate migration, and offline renderers must preserve installation identity themselves.
Test Plan
Stack navigation: #111 → #112 → #113 → #114 → #117 → #120. Parent: FB-4382. Merge in this order. Signing-key rotation documentation is in #120 (FB-4481).
Revision validation: workload annotations remain on the Deployment resource and do not change its pod template. Non-string annotation values are rejected. The final stack passes 20 render regressions and full chart validation; a manual Metadata Service restart and all SQL/Helm hooks passed on local kind.
Note
Medium Risk
Changes install/upgrade behavior (fail-fast validation, metadata rollout triggers, unified DB secret wiring, instance ID guard); misconfigured upgrades or credential rotation still need coordinated DB + restart steps documented in the PR.
Overview
Adds render-time validation (
_validation.tplviavalidate.yaml) so invalid values failhelm template/installinstead of producing broken manifests: duplicate engines or signing key IDs, DNS-length name limits, collisions with chart-owned env/volumes/mounts/paths, reserved rollout annotations, missingpostgresql.hostwhen external, and blockingcustomEngineConfig.instance.idchanges on online upgrade.PostgreSQL credentials now resolve through
fbinstance.postgresSecretNamesopostgresql.credentials.existingSecretapplies to bundled PostgreSQL and the Metadata Service (no chart Secret when set). Metadata rollout checksums hash the full rendered ConfigMap; with an external credential Secret, a resourceVersion checksum triggers restarts on credential rotation. Newmetadata.annotations(Deployment-only, schema-validated strings) supports optional secret-reload controllers without touching the pod template.Engine PVCs honor
storageClassNamewhen set, including an explicit empty string. The bundled Postgres Helm test uses the pinned image, Secret-backed env, andSELECT 1auth check. Docs/README/values comments cover render safeguards, credential rotation restarts, and bundledexistingSecretbehavior.Reviewed by Cursor Bugbot for commit ff94bc4. Bugbot is set up for automated code reviews on this repo. Configure here.