Agents: require style and length consistency with upstream - #11
Merged
moshap-firebolt merged 1 commit intoAug 21, 2026
Merged
Conversation
Adds a "Matching Upstream Conventions" section and a short subsection for reviewing agents. LLM agents default to far more prose than this project uses, in comments, commit bodies, PR descriptions and tests alike, and the existing guidelines only ask for succinctness in the PR comment. Gives concrete budgets drawn from the repository's own history rather than adjectives, so an agent can check its output against something.
moshap-firebolt
commented
Aug 21, 2026
moshap-firebolt
left a comment
Author
There was a problem hiding this comment.
No issues. The budgets are checkable, which is what was missing.
Suggestion. #10 still overshoots them (the 9-line block on parse_in, the test preambles, measurements in the commit/PR). Trim that PR to match this file once this lands — otherwise the first thing an agent reads is a counterexample.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AGENTS.mdcurrently asks for succinctness only in the PR comment. Everything else an agent writes — comments, commit bodies, test tables — is unconstrained, and LLM agents default to far more prose than this project uses. That matters here specifically because this fork's changes are expected to go upstream, where verbose contributions get rejected.Adds a
Matching Upstream Conventionssection with concrete budgets taken from this repository's own history rather than adjectives, so an agent can check its own output:Plus a short
Reviewing Agentssubsection — arguably the higher-leverage half, since a reviewing agent's output lands directly in a PR thread.Worth saying where this came from: the two parser PRs I opened this week both overshot. #10's original commit body was 30 lines, longer than any of the last 60 commits in this repo, and its PR description was several times the length of the surrounding ones. I've since retitled and trimmed it. The guidance is what I'd have wanted to read first.
Note
Low Risk
Documentation-only change to AGENTS.md; no code, security, or runtime impact.
Overview
Extends
AGENTS.mdso agent output (comments, commits, PRs, tests, reviews) matches this fork’s terse upstream style, not default LLM verbosity.Adds Matching Upstream Conventions with concrete budgets: short why comments, dialect-style commit subjects with little or no body, no Firebolt ticket IDs, and tests that pin behaviour without extra tables or commentary.
Adds Reviewing Agents: few sentences per real issue, classify bug vs behaviour change vs suggestion, and skip fmt/clippy nits.
Reviewed by Cursor Bugbot for commit 12e8f2e. Bugbot is set up for automated code reviews on this repo. Configure here.