Skip to content

build firepit with node 24 #10666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aalej wants to merge 1 commit into
base: next
Choose a base branch
from
+1,388 −229
Draft

build firepit with node 24 #10666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/firepit-builder/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:20
FROM node:24

@gemini-code-assist gemini-code-assist Bot Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using Node 24 (which is a non-LTS/Current release, or potentially unreleased depending on the current date) is not recommended for stable production builds. It is highly recommended to use the current active LTS version, Node 22, to ensure stability, compatibility, and that the Docker image is readily available on Docker Hub. Using an unreleased or non-LTS version can lead to build failures or unexpected runtime issues.

FROM node:22


# Install dependencies
RUN apt-get update && \
Expand All @@ -8,8 +8,8 @@ RUN apt-get update && \
RUN curl -fsSL --output hub.tgz https://github.com/github/hub/releases/download/v2.11.2/hub-linux-amd64-2.11.2.tgz
RUN tar --strip-components=2 -C /usr/bin -xf hub.tgz hub-linux-amd64-2.11.2/bin/hub

# Upgrade npm to 9.
RUN npm install --global npm@9.5
# Upgrade npm to 11.
RUN npm install --global npm@11.13

@gemini-code-assist gemini-code-assist Bot Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Pinning to a specific minor/patch version of npm like 11.13 that may not be released or stable yet can cause build failures. It is safer to either use the default stable npm version bundled with the Node.js image (e.g., npm 10 with Node 22) or pin to the major version npm@11 to get the latest stable minor updates automatically.

RUN npm install --global npm@11


# Create app directory
WORKDIR /usr/src/app
Expand Down
Loading
Loading