Rename CrashlyticsOtelContext to PersistenceContext - #4
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors src/android_span_data.cpp by removing Android logging, renaming constants and variables to follow snake_case naming conventions, and updating JNI native registrations to target TelemetryContext instead of CrashlyticsOtelContext. Feedback on the changes highlights a critical JNI resource leak where local references (telemetry_clazz and mutable_clazz) are not deleted, and global references are leaked if native registration fails. A code suggestion is provided to properly clean up these references.
mghaznav
previously approved these changes
Sep 23, 2026
mghaznav
previously approved these changes
Sep 23, 2026
mrober
changed the title
mghaznav
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans up the android_span_data to:
CrashlyticsOtelContexttoPersistenceContextThere is a matching PR in the android repo to match the rename