Skip to content

ci: re-enable ftl tests - #16470

Merged
ncooke3 merged 2 commits into
mainfrom
nc.ftl.reenable
Jul 31, 2026
Merged

ncooke3 merged 2 commits into
mainfrom
nc.ftl.reenable

Conversation

@ncooke3

@ncooke3 ncooke3 commented Jul 30, 2026 •

Copy link
Copy Markdown
Member

Overview This PR re-enables the nightly Firebase Test Lab (FTL) UI tests by removing the && false condition from the infra.ftl.nightly.yml workflow.

Context & Flake Mitigation These tests were previously disabled, likely due to intermittent timeouts when running on FTL infrastructure. During testing of this re-enablement, we identified that the Performance quickstart UI tests occasionally flake because the 10-second hardcoded timeout is too strict for FTL network speeds during Firebase Storage uploads.

To ensure these tests remain stable upon re-enablement, a companion PR has been opened in the quickstart-ios repository to extend the test timeouts and give FTL more leeway: firebase/quickstart-ios#1865

Testing

  • Verified the workflow syntax.
  • Monitored a test run on FTL to confirm the jobs successfully trigger and execute the test suites on the targeted FTL devices.

#no-changelog

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@paulb777 paulb777 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the fix isn't obvious, how about commenting out the Performance FTL test and creating an issue for it, to get us back to green.

@ncooke3 ncooke3 self-assigned this Jul 31, 2026
@paulb777

Copy link
Copy Markdown
Member

Kicked off rerun after merging firebase/quickstart-ios#1865

@ncooke3
ncooke3 marked this pull request as ready for review July 31, 2026 14:33
@ncooke3
ncooke3 merged commit 73d8ca2 into main Jul 31, 2026
34 checks passed
@ncooke3
ncooke3 deleted the nc.ftl.reenable branch July 31, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants