Skip to content

Fix hazelcast session store#256

Closed
gs-saurabh wants to merge 1 commit into
finos:masterfrom
goldmansachs:review-fix-hazelcast-sessionstore-2
Closed

Fix hazelcast session store#256
gs-saurabh wants to merge 1 commit into
finos:masterfrom
goldmansachs:review-fix-hazelcast-sessionstore-2

Conversation

@gs-saurabh

Copy link
Copy Markdown
Contributor

Fix hazelcast session store

@gs-saurabh gs-saurabh requested a review from a team as a code owner June 15, 2026 05:21
@github-actions

Copy link
Copy Markdown

Test Results

20 files  +1  20 suites  +1   21s ⏱️ +2s
83 tests +8  81 ✔️ +6  0 💤 ±0  0 ±0  2 🔥 +2 

For more details on these errors, see this check.

Results for commit e86a778. ± Comparison against base commit 9f285bf.

This pull request removes 2 and adds 10 tests. Note that renamed tests count towards both.
org.finos.legend.server.pac4j.hazelcaststore.HazelcastSessionStoreTest ‑ testSetThenGetFromSession
org.finos.legend.server.pac4j.hazelcaststore.HazelcastSessionStoreTest ‑ testSimulateCookieExpiryThenGetFromSession
org.finos.legend.server.pac4j.gitlab.GitlabClientRenewProfileTest ‑ testRenewUserProfileOnAlreadyInitializedClient_isIdempotent
org.finos.legend.server.pac4j.gitlab.GitlabClientRenewProfileTest ‑ testRenewUserProfileOnUninitializedClient_shouldNotThrowConfigurationNull
org.finos.legend.server.pac4j.gitlab.GitlabClientRenewProfileTest ‑ testRenewUserProfile_invalidGrant_fallsBackToRenewedProfileFromSession
org.finos.legend.server.pac4j.gitlab.GitlabClientRenewProfileTest ‑ testRenewUserProfile_invalidGrant_throwsWhenNoRenewedProfileInSession
org.finos.legend.server.pac4j.hazelcaststore.HazelcastSessionStoreTest ‑ clearingCookieStillCreatesBrandNewSession
org.finos.legend.server.pac4j.hazelcaststore.HazelcastSessionStoreTest ‑ concurrentSetsOnSameSession_doNotLoseUpdates
org.finos.legend.server.pac4j.hazelcaststore.HazelcastSessionStoreTest ‑ evictionFollowedByReAuth_restoresSessionUnderSameSessionId
org.finos.legend.server.pac4j.hazelcaststore.HazelcastSessionStoreTest ‑ getAfterEviction_returnsEmptyAndReSeedsHazelcastEntry
org.finos.legend.server.pac4j.hazelcaststore.HazelcastSessionStoreTest ‑ requestWithNoCookie_createsFreshSession
org.finos.legend.server.pac4j.hazelcaststore.HazelcastSessionStoreTest ‑ setAfterEviction_upsertsHazelcastEntry_andValueIsVisibleClusterWide

@gs-saurabh gs-saurabh closed this Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant