Skip to content

[Repo] fix: Container hostnames as env vars and pinned lint actions #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
finallyjay merged 2 commits into from
Nov 6, 2026
Merged

[Repo] fix: Container hostnames as env vars and pinned lint actions #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c038fba
[Repo] fix: Move the Pi-hole and Plex container hostnames to env vars
finallyjay Nov 6, 2026
bf5f1b2
[Repo] ci: Pin the markdown lint actions by commit SHA
finallyjay Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/lint-markdown.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ jobs:
markdownlint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v7
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false
- uses: DavidAnson/markdownlint-cli2-action@v25
- uses: DavidAnson/markdownlint-cli2-action@696eb3f2509270d7b882d2aa68347bc676e7af34 # v25.0.0
with:
globs: "**/*.md"
3 changes: 3 additions & 0 deletions pihole/.env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Container hostname (shown in the Pi-hole UI)
PIHOLE_HOSTNAME=pihole

# Local domain to access Pi-hole web UI
PIHOLE_LOCAL_DOMAIN=pihole.local

Expand Down
1 change: 1 addition & 0 deletions pihole/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ and `SYS_NICE` capabilities for DNS/DHCP operations.

| Variable | Description |
|-----------------------|----------------------------------------|
| `PIHOLE_HOSTNAME` | Container hostname |
| `PIHOLE_WEB_PASSWORD` | Password for the web admin interface |
| `PIHOLE_LOCAL_DOMAIN` | Domain to access the web interface |

Expand Down
2 changes: 1 addition & 1 deletion pihole/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ services:
pihole:
image: pihole/pihole:latest
container_name: pihole
hostname: tuckfow-home
hostname: ${PIHOLE_HOSTNAME:?PIHOLE_HOSTNAME is required}
restart: unless-stopped
cap_add:
- NET_ADMIN
Expand Down
3 changes: 3 additions & 0 deletions plex/.env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Container hostname (Plex uses it as the default server name)
PLEX_HOSTNAME=plex

# Plex local IP
PLEX_LOCAL_IP=x.x.x.x

Expand Down
1 change: 1 addition & 0 deletions plex/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ organizing and streaming movies, TV shows and music.

| Variable | Description |
|---------------------|----------------------------------------------------|
| `PLEX_HOSTNAME` | Container hostname (default Plex server name) |
| `PLEX_MOUNTED_DATA` | Host path where the media folders are mounted |
| `PLEX_LOCAL_IP` | Local IP of the server running Plex |
| `PLEX_CLAIM` | Optional claim token, only for the first setup |
Expand Down
2 changes: 1 addition & 1 deletion plex/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ services:
plex:
image: linuxserver/plex:latest
container_name: plex
hostname: tuckfow-home
hostname: ${PLEX_HOSTNAME:?PLEX_HOSTNAME is required}
restart: unless-stopped
devices:
- /dev/dri:/dev/dri
Expand Down
Loading