[Draft] Initial implementation of FilCDN Service Level Indicators #75 - #23
[Draft] Initial implementation of FilCDN Service Level Indicators #75#23Fatumayattani wants to merge 2 commits into
Conversation
bajtos
left a comment
bajtos
left a comment
There was a problem hiding this comment.
Thank you, @Fatumayattani, for the pull request. I see many unrelated changes and new files with unclear purpose. Can you please clean up your pull request to contain only the relevant and necessary changes?
There was a problem hiding this comment.
Please remove all .wrangler/ files. Consider adding .wrangler to .gitignore.
There was a problem hiding this comment.
Where is the _file directory coming from? It looks like a duplicate of what we have in src/data. Can you please remove the _file folder from the pull request?
|
|
||
|
|
There was a problem hiding this comment.
Unrelated whitespace changes, please revert.
|
|
||
|
|
There was a problem hiding this comment.
Unrelated whitespace changes, please revert.
| {"id":11,"name":"0011_add_wallet_details_table.sql","applied_at":"2025-09-09 11:44:23"}, | ||
| {"id":12,"name":"0012_add_proof_set_stats.sql","applied_at":"2025-09-09 11:44:23"}, | ||
| {"id":13,"name":"0013_add_wallet_screened_at.sql","applied_at":"2025-09-09 11:44:24"}, | ||
| {"id":14,"name":"0014_m2_5_upgrades.sql","applied_at":"2025-09-09 11:44:24"}] |
There was a problem hiding this comment.
What do we need this file for? Can you please remove it from the PR?
| // preserveExtension: false, // drop .html from URLs | ||
| // preserveIndex: false, // drop /index from URLs | ||
| dynamicPaths: [...clientPaths], | ||
| } |
There was a problem hiding this comment.
Please preserve our current Observable configuration.
There was a problem hiding this comment.
This does not feel right to me. What is this wrangler.toml file for?
|
Hi @bajtos , Thanks for the detailed review and guidance! I’m working on cleaning up the PR to remove unrelated files, revert unintended changes, and focus solely on the relevant SLA implementation. I’ll update the PR once the cleanup is complete. Appreciate your patience and feedback! |
2 participants
This draft PR shows the current work on measuring and visualizing FilCDN SLAs using the data provided.
Progress So Far:
badbitstable from the D1 database snapshot.Current Observations / Challenges:
0%cache hit ratio and0 msTTFB.badbitsappear to be missing, which may be affecting calculations.Looking forward to continuing work on this under your guidance.