feat: UCAN 1.0 - #2
Merged
Merged
Conversation
frrist
reviewed
May 11, 2026
frrist
left a comment
frrist
left a comment
Member
There was a problem hiding this comment.
getting some early comments in, looks great so far! just a lot to review 😅
Comment on lines
19
to
33
| func doRegister(cmd *cobra.Command, args []string) error { | ||
| c, _, _, id := lib.InitClient(cmd) | ||
| c, _, _, _ := lib.InitClient(cmd) | ||
|
|
||
| endpoint, err := url.Parse(args[0]) | ||
| id, err := did.Parse(args[0]) | ||
| cobra.CheckErr(err) | ||
|
|
||
| proof, err := delegation.Parse(args[1]) | ||
| endpoint, err := url.Parse(args[1]) | ||
| cobra.CheckErr(err) | ||
|
|
||
| _, err = c.AdminProviderRegister(cmd.Context(), id.Signer, endpoint.String(), proof) | ||
| _, err = c.AdminProviderRegister(cmd.Context(), id, endpoint.String()) | ||
| cobra.CheckErr(err) | ||
|
|
||
| cmd.Println("Provider registered successfully") | ||
| return nil | ||
| } |
Member
There was a problem hiding this comment.
Lets remove cobra.CheckErr calls here and just return the error to the caller. registerCmd invokes doRegister as a RunE method which expects an error type. The behavior of CheckErr isn't what we want here, I think: https://github.com/spf13/cobra/blob/v1.10.2/cobra.go#L235
More generally, lets really try and limit our usage of cobra.CheckErr to init methods, flag binding, and top level CLI packages.
| client.WithServiceURL(fmt.Sprintf("http://%s:%d", cfg.Server.Host, cfg.Server.Port)), | ||
| ) | ||
| endpoint, err := url.Parse(fmt.Sprintf("http://%s:%d", cfg.Server.Host, cfg.Server.Port)) | ||
| cobra.CheckErr(err) |
Member
There was a problem hiding this comment.
Comment on lines
+44
to
+45
| if c.signer.DID() != c.uploadServiceID { | ||
| return nil, fmt.Errorf("admin operation not permitted: signer DID %s does not match upload service ID %s", c.signer.DID(), c.uploadServiceID) |
Member
There was a problem hiding this comment.
Thought: Feels like this ought to be a middleware since this is ~ACL of who/what can call these methods.
Comment on lines
+28
to
+43
| fields := []zap.Field{ | ||
| zap.Stringer("issuer", inv.Issuer().DID()), | ||
| zap.Stringer("subject", inv.Subject().DID()), | ||
| zap.Stringer("command", inv.Command()), | ||
| zap.Any("arguments", inv.Arguments()), | ||
| } | ||
| if inv.Audience() != nil { | ||
| fields = append(fields, zap.Stringer("audience", inv.Audience().DID())) | ||
| } | ||
| if len(inv.Metadata()) > 0 { | ||
| fields = append(fields, zap.Any("metadata", inv.Metadata())) | ||
| } | ||
| if len(inv.Proofs()) > 0 { | ||
| fields = append(fields, zap.Stringers("proofs", inv.Proofs())) | ||
| } | ||
| log := logger.With(zap.Dict("invocation", fields...)) |
Member
There was a problem hiding this comment.
https://github.com/uber-go/zap/blob/master/zapcore/marshaler.go#L23-L32 is nice for this type of thing, lets us re-use it across calls.
Upgrades ucantone and makes changes here to support the deferred argument/metadata types. refs fil-forge/ucantone#8
alanshaw
added a commit
to fil-forge/libforge
that referenced
this pull request
May 19, 2026
Adds a "proof store" interface and implementation allowing you to create one from a UCAN container. The interface is a thin wrapper around the lower level utility functions for obtaining proof chains (and attestations) for invocations. Note: this was implemented in fil-forge/sprue#2 originally but I need it also in indexing service. Renames `capabilities` to `commands` and renames `capabilities.MustNew(...)` to `capabilities.MustParse(...)`. depends on fil-forge/ucantone#14
Contributor
This was referenced May 22, 2026
For expected errors, this confirms that we find the correct error. For unexpected errors, this makes the error message visible in the test failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the code base to UCAN 1.0, as implemented by https://github.com/fil-forge/ucantone.
Note: Does not implement replication yet.