Repository navigation
Conversation
SessionClock tracks studied time (study phases only, pauses excluded). Stopping a running session shows the summary card with a way to take the stop back; a stop within the first seconds still goes straight to idle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 1 of the review fixes.
SessionClocknow tracks the time actually studied: study phases only, pauses excluded (studied(at:)).studiedMinutesuses it instead ofstudyMinutes * rounds.stopon a running session lands on the summary card ("stopped", minutes studied, average focus or "round n of m", nudges) instead of the idle card, so history and nudges are no longer thrown away.phaseChanged(), so it also covers a resumed session.--state stopped.Verification
swift run focus-check: 37 checks passed (5 new: stop with a pause in between, stop during a break, full session excludes breaks, stop right after start, resume after stop).scripts/build-app.shsucceeded; tested in the real app opened fromdist/FocusGuard.app, panel opened by clicking the status item, pointer driven with CGEvents, captured withscreencapture -l:Note: a stop under 30 s shows "0 min" (rounded), which is honest but may look odd.