deps: Update dependency protobuf to v34.1#703
Conversation
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughUpdated the Bazel module dependency for Changes
Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly Related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@third_party/java/deps.MODULE.bazel`:
- Line 1: Revert or hold the protobuf version bump: undo the change to
bazel_dep(name = "protobuf", version = "34.1") in
third_party/java/deps.MODULE.bazel (or replace it with the previous pinned
version) and add a blocking note/comment/guard so the PR does not merge until
the 34.1 artifact pinning and Bazel CcInfo/toolchain resolution are confirmed;
ensure the CI/merge pipeline requires successful post-upgrade artifact pinning
before automerging this dependency update.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 27ea7b27-6e76-4023-aca0-797e12168f13
⛔ Files ignored due to path filters (1)
MODULE.bazel.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
third_party/java/deps.MODULE.bazel
| @@ -1,4 +1,4 @@ | |||
| bazel_dep(name = "protobuf", version = "34.0.bcr.1") | |||
| bazel_dep(name = "protobuf", version = "34.1") | |||
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Read-only verification: inspect Bazel module versions implicated by the failure.
# 1) Locate module/workspace files
fd 'MODULE.bazel|WORKSPACE|WORKSPACE.bazel|deps.MODULE.bazel'
# 2) Show versions/refs for protobuf, rules_go, rules_cc, bazel_skylib (if present)
rg -n -C2 'bazel_dep\(|rules_go|rules_cc|protobuf|bazel_skylib' MODULE.bazel **/MODULE.bazel **/*deps*.bazel WORKSPACE WORKSPACE.bazel 2>/dev/null
# 3) Check if repo has overrides/pins that may force incompatible rules_go/toolchains
rg -n -C2 'override|archive_override|git_override|single_version_override|go_toolchains' MODULE.bazel **/MODULE.bazel **/*deps*.bazel 2>/dev/nullRepository: ffortier/mono
Length of output: 2546
🌐 Web query:
What are the compatibility requirements between Bazel 9.x, rules_go, and rules_cc regarding the removed CcInfo symbol, and which rules_go version first supports the new cc_info.bzl load path?
💡 Result:
Bazel 9.x requires loading CcInfo from the new rules_cc path "@rules_cc//cc/common:cc_info.bzl" instead of the legacy built-in location, due to the removal of native C++ rules and providers from Bazel core (now in rules_cc). This affects rules_go and rules_cc when using cgo or C++ interop, as older loads like "CcInfo" without explicit path fail with symbol errors. rules_cc versions around 0.1.0+ (e.g., 0.1.1, 0.2.x used in Bazel 9.0.1) provide cc/common/cc_info.bzl defining CcInfo. rules_go has used "@rules_cc//cc/common:cc_info.bzl", "CcInfo" since at least v0.29.0 (2021, removing rules_cc dep but retaining load), compatible with Bazel 9.x via recent rules_cc. No specific "first supports new path" version found, but master/cgo.bzl confirms ongoing use; v0.59.0 (2025) requires Bazel >=6.5.0. Compatibility: Use rules_cc >=0.1.0, rules_go >=0.29.0 (ideally latest v0.59.0+), Bazel 9.x. Update loads to "@rules_cc//cc/common:cc_info.bzl", "CcInfo". Test with Bazel 9.0.1rc1+ for improved errors.
Citations:
- 1: Bazel 9: bad error message when CcInfo not loaded bazelbuild/rules_cc#566
- 2: https://github.com/bazelbuild/bazel/releases
- 3: https://bazel.googlesource.com/rules_cc/
- 4: https://github.com/bazelbuild/rules_go/blob/master/go/private/rules/cgo.bzl
- 5: Make go_binary expose CcInfo bazel-contrib/rules_go#2445
- 6: Optimize CcInfo computation bazel-contrib/rules_go#4020
- 7: Create a rules_go release removing dependency from rules_cc bazel-contrib/rules_go#2975
- 8: rules_cc@0.1.1 bazelbuild/bazel-central-registry#3745
🏁 Script executed:
# Read the actual file under review
cat -n third_party/java/deps.MODULE.bazelRepository: ffortier/mono
Length of output: 1321
🏁 Script executed:
# Get full content of main MODULE.bazel to see rules_go, rules_cc, and bazel version constraint
cat -n MODULE.bazel | head -100Repository: ffortier/mono
Length of output: 4523
🏁 Script executed:
# Search for rules_go and rules_cc versions more explicitly across all MODULE.bazel files
rg -n 'rules_go|rules_cc' --type bazelRepository: ffortier/mono
Length of output: 12475
🏁 Script executed:
# Check for bazel_version directive
rg -n 'bazel_version|bazel.*version' MODULE.bazelRepository: ffortier/mono
Length of output: 725
🏁 Script executed:
# Check for bazel_version directive
rg -n 'bazel_version' MODULE.bazelRepository: ffortier/mono
Length of output: 39
🏁 Script executed:
# Check MODULE.bazel.lock for hints about rules_go
head -50 MODULE.bazel.lockRepository: ffortier/mono
Length of output: 6706
🏁 Script executed:
# Look for any other references to protobuf version or java deps version history
rg -n 'protobuf' third_party/java/ --type bazelRepository: ffortier/mono
Length of output: 198
Block merge until protobuf 34.1 artifact pinning succeeds.
This bump is breaking Renovate's post-upgrade artifact step (Bazel analysis fails on CcInfo/toolchain resolution), which will land a non-reproducible or broken dependency state—especially with automerge enabled.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@third_party/java/deps.MODULE.bazel` at line 1, Revert or hold the protobuf
version bump: undo the change to bazel_dep(name = "protobuf", version = "34.1")
in third_party/java/deps.MODULE.bazel (or replace it with the previous pinned
version) and add a blocking note/comment/guard so the PR does not merge until
the 34.1 artifact pinning and Bazel CcInfo/toolchain resolution are confirmed;
ensure the CI/merge pipeline requires successful post-upgrade artifact pinning
before automerging this dependency update.
ffortier
force-pushed
the
renovate/protobuf-monorepo
branch
8 times, most recently
from
5cc6763 to
a76cd6c
Compare
ffortier
force-pushed
the
renovate/protobuf-monorepo
branch
14 times, most recently
from
f6a1001 to
60e1749
Compare
ffortier
force-pushed
the
renovate/protobuf-monorepo
branch
5 times, most recently
from
7dbfbcf to
114b3cb
Compare
ffortier
force-pushed
the
renovate/protobuf-monorepo
branch
10 times, most recently
from
f18c2b6 to
df53038
Compare
ffortier
force-pushed
the
renovate/protobuf-monorepo
branch
8 times, most recently
from
df696f8 to
350d053
Compare
ffortier
force-pushed
the
renovate/protobuf-monorepo
branch
11 times, most recently
from
e2ee9e5 to
651cad7
Compare
2 participants
This PR contains the following updates:
34.0.bcr.1→34.1Release Notes
protocolbuffers/protobuf (protobuf)
v34.1: Protocol Buffers v34.1Announcements
Bazel
protocoptflag out of theccdir, since it is not a c++-specific flag. (3db9fd1)763c5da)C++
5583485)523a6a4)763c5da)Java
ab3d7f0)Python
763c5da)Other
mkdircommand to followINTEGRITY_FILElocation. (e700d7d)f5ccaf3)Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate.