fix(ci): a PR based on anything but main ran no CI and reported as clean - #1
Merged
Merged
Conversation
`branches:` under `pull_request` filters the BASE branch, not the head, so a stacked PR matched nothing, ran zero checks, and `gh pr view` still reported MERGEABLE / CLEAN with an empty check list. Drop the filter under `pull_request` only; the `push:` filter is unchanged. Verified by actions-pin.py PIN007 (fevra-dev/Workflow): non-zero before, 0 after. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0177zHe8eJQppFt2oaf9URZp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub applies
branches:underpull_requestto the base branch, not thehead. A stacked PR — one based on another feature branch — therefore matched no
filter and ran no CI at all, while
gh pr viewreported it asMERGEABLE / CLEANwith an empty check list. An empty check list is not apassing check list, and only the emptiness distinguished them from a green run.
Actualised once in fevra-dev/Workflow (PR #92 merged to main with zero checks
ever run). Latent in 13 workflow files across 9 repos, seeded by the shared
/macdaddyCI template. This repo is one of them.Fix: drop the filter under
pull_requestonly. Thepush:filter is kept — itis a legitimate branch restriction and is unaffected. Fork PRs still receive no
secrets beyond a read-only GITHUB_TOKEN, so this does not widen what an
untrusted PR can reach.
Verified with
.githooks/actions-pin.pyPIN007 (fevra-dev/Workflow): non-zerobefore, 0 after.