Fix QML Material List Modal failing to load #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The qmldir file incorrectly referenced a non-existent MaterialEditorQML.qml file as a singleton. The MaterialEditorQML singleton is registered from C++ via qmlRegisterSingletonType, so this qmldir entry was causing the QML engine to fail when loading the MaterialListModal. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The
qml/qmldirfile incorrectly referenced a non-existentMaterialEditorQML.qmlfile as a singleton:The
MaterialEditorQMLsingleton is actually registered from C++ viaqmlRegisterSingletonTypeinmainwindow.cpp, not from a QML file. This incorrect qmldir entry caused the QML engine to fail when trying to load the module.Changes
singleton MaterialEditorQML 1.0 MaterialEditorQML.qmlline fromqml/qmldirTest plan
🤖 Generated with Claude Code