⚡ proposed fixes - #57
Open
rneswold wants to merge 1 commit into
Open
Conversation
This was generated by Gemini. It proposes to fix two issues with the previous version: - It built the code coverage executable each time it was run. Since the utility is written in Rust, it added quite a bit of time to the workflow. - It unpacked and rebuilt the cache each time, yet I've never saw it use the contents. I've only ever seen it unconditionally build the Rust project (twice! once for clippy and for the unit tests) Gemini proposes that this version uses the cache properly, so it should only rebuild crates that are updated. It also uses a workflow that has a prebuilt instance of the code coverage tool so we don't need to build it over and over. This commit is being made to share the changes with others that are more familiar with GitHub workflows. It looks good to me, but that's not saying much.
mgonzal1
reviewed
Jul 31, 2026
| uses: actions/cache@v5 | ||
| continue-on-error: false | ||
| - name: Setup Rust Cache | ||
| uses: Swatinem/rust-cache@v2 |
Contributor
There was a problem hiding this comment.
To reduce security risks, I recommend to use onlhy github actions from github or verified creators.
See an example of a recent vulnerability : https://semgrep.dev/blog/2025/popular-github-action-tj-actionschanged-files-is-compromised/
Contributor
Author
|
I don't know if we should merge this or simple use it for discussion on improving the workflow. @jacob-curley-fnal and I have a discussion in his PR which might reject this PR altogether. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was generated by Gemini. It proposes to fix two issues with the previous version:
Gemini proposes that this version uses the cache properly, so it should only rebuild crates that are updated. It also uses a workflow that has a prebuilt instance of the code coverage tool so we don't need to build it over and over.
This PR is being made to share the changes with others that are more familiar with GitHub workflows. It looks good to me, but that's not saying much.