Repository navigation
ci: run JS CI on root tooling changes and drop missing Dependabot labels - #131
Merged
Merged
Conversation
Root package.json, package-lock.json and eslint.config.js changes (e.g. Dependabot bumps of eslint/typescript-eslint) previously skipped JS CI, so lint was never exercised. Also remove the 'dependencies', 'php' and 'ci' labels from dependabot.yml since they don't exist in the repo. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0168a1udJiu9DjAhMHTNVUxD
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
js-ci.ymlnow also triggers onpackage.json,package-lock.jsonandeslint.config.jsat the repo root. Dependabot's npm group bumps (eslint, typescript-eslint, prettier…) only touch root files, so JS CI — including lint — was being skipped on them (e.g. chore(deps): bump the npm group across 1 directory with 6 updates #130).dependencies,phpandcilabels fromdependabot.yml, since they don't exist in the repo and Dependabot was commenting about them on every PR.Uses the
ci:commit type, which is hidden inrelease-please-config.json, so it doesn't trigger a new release.🤖 Generated with Claude Code
https://claude.ai/code/session_0168a1udJiu9DjAhMHTNVUxD
Generated by Claude Code