Skip to content

feat: 重构 CalloutBanner 表面与语义标并支持 Toast action 保持常驻 - #48

Open
qqqqqf-q wants to merge 1 commit into
mainfrom
feat/memoh-337-callout-banner-redesign
Open

qqqqqf-q wants to merge 1 commit into
mainfrom
feat/memoh-337-callout-banner-redesign

Conversation

@qqqqqf-q

Copy link
Copy Markdown
Member

关联 Issue

改动内容

  1. CalloutBanner 默认页面级表面重构(size="default"):
    • 将页面级横幅容器从半透明语义洗色改为实色卡片表面(bg-card + 浅色 border-border / 深色无框 dark:border-0,rounded-menu-shell),避免在点阵等背景上透底发粉。
    • 新增可选 tag?: string 属性:传入语义标文案时在标题旁渲染 rounded-sm 轻量语义标并隐藏左侧状态图标,消除图标与中英文字体的光学比例冲突;未传 tag 的存量调用点保留原图标兜底以维持语义兼容。
  2. ToastAction 新增 dismissOnClick?: boolean(默认 true):
    • 支持复制类等原地动作将 dismissOnClick 设为 false,点击按钮后保持当前报错 Toast 常驻不关闭,不影响现有跳转/撤销类按钮的默认关闭行为。

验证结果

  • 自动检查:pnpm --filter @felinic/ui type-check(vue-tsc --build)、ESLint、UI 契约守卫检查均通过。
  • Agent 无头浏览器自检:在亮/暗双主题下核实了 CalloutBanner 实色表面与 Toast dismissOnClick: false 行为(非人工 QA)。

⚠️ No human QA — this PR has not been verified by a human yet. Remove this line once a human confirms the happy path.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T17:56:46.167496Z 110a2de PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 110a2de64f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

</p>
<p
v-if="title"
class="break-words font-medium text-foreground"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Allow the title flex item to shrink before wrapping

When title contains a long unbroken value such as a URL, identifier, or filename, the new flex wrapper makes the <p> a flex item with the default min-width: auto. Its min-content width prevents it from shrinking to the banner's available width, so break-words no longer keeps the title inside the surface and it can overflow into the dismiss/action area. Previously the paragraph was a normal block and wrapped within its parent. Add min-w-0 to the title flex item or use a wrapping rule that also reduces its min-content width.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant