Repository navigation
fix: 修复侧栏悬停态残留双高亮并补齐根元素明暗 color-scheme - #46
Merged
qqqqqf-q merged 1 commit intoNov 19, 2026
Merged
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI 仓库:
felinics/uiAuthor
Type
Summary
修复宿主设置侧栏双高亮残留以及根元素缺失明暗
color-scheme声明两项 UX/UI 问题(对应B-15、B-16公共组件库部分):B-15):src/lib/scroll-hover.ts中忽略非mouse/pen指针(如touch)触发的悬停标记,避免触屏点击长期锁定悬停态。hovered节点期间按需挂载ownerDocument级清理监听(一旦清除或dispose即刻解绑):覆盖跨出侧栏边界移动到内容区/弹窗遮罩的pointermove/pointerdown、焦点离栏时的focusin、窗口失焦/标签页隐藏(blur/visibilitychange),以及 Reka UI 弹窗/下拉菜单打开将document.body.style.pointerEvents设为none时的MutationObserver同步清除。src/components/settings/NavItem.vue中将激活态的font-medium与默认态的font-[430]设为互斥分支,进一步拉开当前页签与非激活项的视觉层级。color-scheme声明(B-16):src/style.css的:root, [data-color-scheme-preview="memoh"]声明color-scheme: light;,在.dark, .dark [data-color-scheme-preview="memoh"]声明color-scheme: dark;,使原生表单控件与滚动条与当前亮暗主题保持一致。Related Issues
Validation
@felinic/ui构建与类型检查:mise exec -- pnpm run build(含vue-tsc --build与vite build)通过。felinics/Memoh宿主packages/ui运行mise run lint:contract,通过(0 新增违规)。127.0.0.1:8091Vite 代理本地后端18080/18081,ego-browser登录admin实测,仅代表 Agent 自测,非真人 QA):color-scheme:外观设置切至浅色时getComputedStyle(document.documentElement).colorScheme === 'light',切回深色时为'dark'(验证后已恢复深色模式)。bodypointer-events”“关闭弹窗后”“touch指针点击”四种场景,[data-settings-nav-item][data-pointer-hover]均立即归零,无双高亮残留。Screenshots / Recordings
Human QA