Repository navigation
Conversation
配合 @felinic/ui 的职责拆分(卡片外壳提供左右缩进,列表提供行节奏,行只排 内容),更新 packages/ui 子模块并迁移页面: - 删除卡片内约 30 处手写的 px-4 / mx-4,p-N 改为 py-N,左右留白交给卡片; - 外观 Advanced 弹窗去掉不生效的 mx-0 min-h-0 py-0 覆盖,修复 "Examples in sidebar" 比 "Code highlight" 多缩进 16px; - Bot 网络 Advanced 弹窗改用 SettingsList,修复同类的多缩进; - 压缩日志表格与分页、模型列表分页、记忆图谱画布改用 SettingsBleed 贴边; - 视频服务商模型区、App 详情依赖列表改用 SettingsSection,后者顺带去掉 一处双分割线; - 转写服务商去掉自包的工具区包装,由 SettingsSection #actions 统一处理; - 窄屏 provider-configuration 规则改按 data-settings-row 匹配行; - 组件墙新增 SettingsList / SettingsBleed 示例。 Linear: MEMOH-269
About 身份卡是自由排版的内容而不是设置行列表,不应套用设置卡片的行缩进 (左右 16px 加自身上下 20px 会四边不等距)。抽成页面私有组件 about-identity-card.vue,外壳改用 SurfaceCard 自带的四边 20px 内边距,外观与 改动前一致。 模板原样搬移,仅 displayVersion 改为 prop version,资源链接数据随组件迁移。 UI 契约守卫的遗留计数按文件记录,随代码一并转到新文件(px 8 → 页面 2 + 组件 6,alpha 2 → 1 + 1),总量不变。 Linear: MEMOH-269
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cd67ed26bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <div | ||
| v-if="oauthStatusLoading && !oauthStatus" | ||
| class="mx-4 flex min-h-[3.75rem] items-center justify-center py-3" | ||
| class="flex min-h-[3.75rem] items-center justify-center py-3" |
There was a problem hiding this comment.
Complete the OAuth block inset migration
When a saved remote MCP server requires manually supplied OAuth credentials, the block at mcp-server-detail.vue:340 still has mx-4. Since the updated SettingsSection supplies the horizontal inset itself, those fields now receive twice the inset of the authorization row above them, reducing their available width and breaking alignment. The pending device-code block in providers/components/provider-form.vue:338 retains the same obsolete margin. Remove these remaining margins as part of the migration so the card remains the single spacing owner, consistent with M2 in the frontend rules required by apps/web/AGENTS.md.
AGENTS.md reference: apps/web/AGENTS.md:L9-L9
Useful? React with 👍 / 👎.
|
Format check passed; removed |
卡片外壳已统一提供左右缩进,这三处仍手写 mx-4,会比上下行多缩进 16px。 同步更新两条仍描述旧缩进来源的注释。
渠道设置的高级弹窗把字段行直接放在弹窗正文里,行节奏改由列表提供后, 这些行失去行高、上下留白和分隔线;与 Bot 网络高级弹窗一样包进 SettingsList。 新手引导第 3 步的模型行放在普通网格里,没有卡片外壳提供缩进,由调用处保留 原来的左右 16px。子模块指针更新到包含文档更正的提交。
Author
Type
Summary
问题:外观设置 → Advanced 弹窗里,"Examples in sidebar" 比下面的 "Code highlight" 和弹窗标题多缩进了 16px;Bot 网络和渠道设置的 Advanced 弹窗也一样。
原因:设置卡片本身不留边,左右 16px 缩进写在每一行上。行放进弹窗时就会多出这 16px,而调用方写的
mx-0覆盖在 Tailwind v4 下按样式表顺序被静默吃掉了。卡片里的非行内容(段落、表格、图表、分页条)只能各自手写px-4,全仓约 30 处。做法:配合 felinics/ui#44 按层划分职责——卡片外壳统一提供左右留白,列表提供行节奏,行只排内容,需要贴边的内容用
SettingsBleed声明。本 PR 更新packages/ui子模块并迁移页面:px-4/mx-4,p-N改为py-N。mx-0 min-h-0 py-0覆盖。SettingsList,只拿行节奏,不再多缩进。SettingsBleed贴到卡片边缘,外观不变。SurfaceCard改为SettingsSection,与语音、转写、模型服务商的模型区一致。SettingsList,与 Bot 网络弹窗一致。SettingsSection。SettingsSection #actions统一处理。about-identity-card.vue,外壳改用SurfaceCard,四边 20px 不变。它是自由排版的内容,不套设置列表的行缩进。UI 契约守卫的遗留计数随代码转到新文件,总量不变。provider-configuration规则改按data-settings-row匹配行。SettingsList/SettingsBleed示例。可见变化(其余页面改动前后逐像素一致):
合并顺序:felinics/ui#44 已合并,本 PR 的子模块指针已更新到 felinics/ui main 上的合并提交
13b5a16。Related Issues
Validation
以下为 Agent 自检,不是真人 QA。
86ae1db1b,ui8be0fdd)各起一个宿主机 vite,接同一个后端。scripts/check-ui-contract.mjs通过,3 条警告改动前已存在;webvue-tsc与 uivue-tsc --build通过;提交钩子的 eslint 通过。apps/webvitest 有 13 个文件、93 个用例失败,与 main 基线完全相同,属于本机环境问题,与本 PR 无关;About 页测试通过。check-ui-contract通过。Screenshots / Recordings
截图均来自上述运行中的 dev 环境,左为 main,右为本 PR。
外观 → Advanced 弹窗(浅色、深色):
Bot 网络 → Advanced 弹窗:
Bot 详情左上角 Bot 卡片(放大 2 倍):
语音服务商、视频服务商模型区标题栏:
App 详情依赖列表(深色):
组件墙上的 SettingsList / SettingsBleed 示例(浅色、深色):
Human QA