Repository navigation
fix: preserve starter prompt errors with dismissible retry feedback - #1706
Open
LittleSound wants to merge 2 commits into
Open
LittleSound wants to merge 2 commits into
LittleSound wants to merge 2 commits into
Conversation
sheepbox8646
approved these changes
Nov 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Author
Type
Summary
Starter prompt generation failures previously became successful empty responses, hiding the suggestion area on initial load and reducing refresh failures to a generic toast. Propagate operational failures through the standard Problem Details boundary and show a localized error with its Request ID while retaining cached suggestions and retry controls.
The error banner has its own dismiss button. Dismissing it preserves suggestions and Refresh, including when no suggestions are cached. A subsequent failed attempt shows the new error again. Missing title-model configuration retains its existing empty-state behavior; provider diagnostics remain server-side.
Related Issues
MEMOH-240
Validation
pnpm run lint --fix: no errors, 20 existing warnings.pnpm --filter @memohai/web run typecheck: passed (the root package has no typecheck script).git diff --check: passed; guard reports 3 existing warnings.memoh-240stack, backendlocalhost:18380, Vitehttp://127.0.0.1:25101. Generated suggestions, disabled the local title model, confirmed an actual HTTP error with Request ID, dismissed the banner without losing suggestions, and retried to confirm a new failure reappears. Repeated without cached suggestions: dismiss leaves Refresh available. Restored the model and confirmed successful retry clears the error.2026-11-22 合并冲突验证(Agent)
origin/main的fb0014607478cd1666598fc5dfbc9379b17c2a90。唯一文本冲突在zh.json的chatExamples:保留本 PR 的dismissError,同时采用主分支无句号的noBot;其余代码自动合并,未扩大功能范围。dismissError外,与主分支文案一致。apperror、server、handlers测试通过。Web 类型检查通过;根包没有typecheck脚本,使用pnpm --filter @memohai/web run typecheck。pnpm run lint --fix无错误、33 条既有警告;UI contract 和 settings rows 守卫通过;相对主分支的git diff --check通过。完整mise run lint(包含 Go lint)也通过,耗时约 6 分钟。最终提交771b18649的全部提交钩子(ESLint、Go lint、所选 Go 包测试)通过。memoh-pr1706,Serverhttp://localhost:18480、Channel18481、Webhttp://127.0.0.1:25100/bot/gamer,服务均健康,后端挂载当前合并后的工作区。t.Fatal后的 SA5011 告警,换用任务独立缓存后同一代码通过,未关闭任何规则(上游同类记录)。提交钩子中的recovers_subscriber_buffer_overflow曾出现一次 5 秒时序超时,单独复跑及随后完整钩子重跑通过;未修改无关测试。Screenshots / Recordings
本轮冲突解决后的真实应用截图(2026-11-22):
Local development data only.
Error banner with its independent close button:

After dismissal, suggestions and Refresh remain:

A subsequent failure is shown again:

With no cached suggestions, dismissing still preserves Refresh:

Successful retry after restoring the local model:

Human QA