feat: /joinchat command and group chat notice in ride messages#5
Merged
feat: /joinchat command and group chat notice in ride messages#5
Conversation
When a group is attached to a ride, all ride messages now show a notice with /joinchat #ID instructions so participants know how to join. The notice disappears automatically on detach. Attach and detach now update all existing ride messages across all chats. /joinchat is a new private-only command: any joined participant can send it to the bot to receive a single-use invite link, reusing the existing GroupManagementService.addParticipant logic. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Both branches added new private commands — keep joinchat (this branch) and fromstrava (main); merged bot.commandDescriptions accordingly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adding both /joinchat (this branch) and /fromstrava (main) brings the total private-only command count to 13. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/joinchat #IDinstructions when a group is attached to the ride; the notice is absent (no extra whitespace) when no group is attached/attachand/detachnow update all existing ride messages across all chats so the notice appears/disappears immediately everywhere/joinchatprivate command: any joined participant can send it to get a single-use invite link to the group chat, reusing the existingGroupManagementService.addParticipantlogicTest plan
/attach: all existing ride messages (in all chats) show the group chat line; the newly posted group message also shows it/detach: all ride messages remove the group chat line/joinchat #IDfrom a non-participant → error reply/joinchat #IDfrom a joined participant → invite link sent (or creator notified if user hasn't started the bot)/joinchat #IDfor a ride with no attached group → error reply./run-tests.sh --mode basic🤖 Generated with Claude Code