Disable libdnf5 plugins during tests#97
Open
evan-goode wants to merge 1 commit into
Open
Conversation
Author
|
The issue was moved to https://forge.fedoraproject.org/ci/tickets/issues/538. |
|
To avoid making permanent changes on a machine, consider putting it in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://pagure.io/fedora-ci/general/issue/538#comment-1001814.
Disable libdnf5 plugins during tests so newly-installed libdnf5 don't alter the behavior of DNF5 and break subsequent tests. We want to test whether packages (including libdnf5 plugins) are installable/upgradable/downgradable/removable, not whether they work correctly when executed, in the testing environment, without being configured, etc.
As mentioned in the comment, a better solution might be to only disable plugins which are not installed by default. One way to do this would be to list currently-enabled plugins:
and then run DNF5 with
dnf5 --disable-plugin=\* --enable-plugin=$MYPLUGINLIST. But that would be a more involved change, I think we'd need to update everywhere$YUMDNFCMDis called.