Conversation
IncrementalReader seeked to a remembered offset without ever checking the file length, so a truncated or rewritten log left the offset past the end. The read returned nothing and the reader re-sent the buffer it had built before the truncation, forever. Compare the length against the offset first and start over when the file is shorter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IncrementalReaderseeked to its remembered offset without checking how long the file actually was, so once a log was truncated or rewritten shorter the offset sat past the end, every read came back empty, and the pane kept re-sending the buffer it had built before the truncation. It now compares the length against the offset and starts over when the file has shrunk. Three tests cover it: appending still reads incrementally, a rewritten file replaces the buffer, and an emptied file empties the pane.Closes #9