Skip to content

Handle URL string icons #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
puneetdixit200 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle URL string icons #774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ To be released.

[#316]: https://github.com/fedify-dev/fedify/issues/316
[#418]: https://github.com/fedify-dev/fedify/issues/418
[#420]: https://github.com/fedify-dev/fedify/issues/420
[#619]: https://github.com/fedify-dev/fedify/issues/619
[#735]: https://github.com/fedify-dev/fedify/issues/735
[#736]: https://github.com/fedify-dev/fedify/issues/736
Expand Down Expand Up @@ -232,6 +233,12 @@ To be released.
- Added a `meterProvider` option to `createFederation()` so mock contexts can
expose a test OpenTelemetry meter provider. [[#316], [#619], [#755]]

### @fedify/vocab

- Fixed Activity Vocabulary parsing so URL string `icon` values are exposed
as `Link` instances instead of being dereferenced as remote `Image`
documents. [[#420]]

### @fedify/uri-template

- Added *@fedify/uri-template*, a dependency-free RFC 6570 URI Template
Expand Down
9 changes: 5 additions & 4 deletions packages/fedify/src/federation/webfinger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,12 +330,13 @@ async function handleWebFingerInternal<TContextData>(
});
}
}
for await (const image of actor.getIcons()) {
if (image.url?.href == null) continue;
for await (const icon of actor.getIcons()) {
const href = icon instanceof LinkObject ? icon.href : icon.url;
if (href?.href == null) continue;
links.push({
rel: "http://webfinger.net/rel/avatar",
href: image.url.href.toString(),
...(image.mediaType != null && { type: image.mediaType }),
href: href.href.toString(),
...(icon.mediaType != null && { type: icon.mediaType }),
});
}

Expand Down
Loading