Repository navigation
chore: upgrade SDK to .NET 8 - #34
Conversation
|
Warning Review limit reachedNext included review available in 48 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (12)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe SDK and related projects now target .NET 8. Legacy .NET Core 3.1 compatibility paths were removed from serialization, HTTP handling, and model construction. Documentation and test dependencies were updated accordingly. Changes.NET 8 migration
Estimated code review effort: 2 (Simple) | ~15 minutes Merge Risk: ⚪ Minimal · up to The SDK upgrade and related project, example, test, and packaging changes are supported by successful validation; the remaining timeout integration check is optional follow-up rather than evidence of a production defect. No actionable merge-blocking risk remains after normal review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Upgrades the SDK, tests, and examples from .NET 6/.NET Core 3.1 to .NET 8 while retaining supported legacy targets.
Changes:
- Updates target frameworks, SDK pinning, dependencies, and examples.
- Removes obsolete compatibility code and refreshes serialization behavior.
- Updates Source Link metadata and supported-version documentation.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Review summary |
|---|---|
tests/FeatBit.ServerSdk.Tests/UriTests.cs |
Updates the .NET documentation link. |
tests/FeatBit.ServerSdk.Tests/FeatBit.ServerSdk.Tests.csproj |
Retargets tests and updates testing dependencies. |
src/FeatBit.ServerSdk/Model/Segment.cs |
Removes the obsolete .NET Core 3.1 constructor. |
src/FeatBit.ServerSdk/Model/FeatureFlag.cs |
Removes the obsolete .NET Core 3.1 constructor. |
src/FeatBit.ServerSdk/Json/ReusableJsonSerializerOptions.cs |
Removes legacy configuration, but changing the public type to static causes a moderate source-compatibility break; retain the class declaration. |
src/FeatBit.ServerSdk/FeatBit.ServerSdk.csproj |
Updates target frameworks, package metadata, and Source Link configuration. |
src/FeatBit.ServerSdk/Events/DefaultEventSender.cs |
Simplifies runtime-specific handler selection. |
src/FeatBit.ServerSdk/DataSynchronizer/DataSet.cs |
Removes the legacy deserialization fallback. |
README.md |
Updates supported framework documentation. |
global.json |
Pins the .NET 8 SDK. |
examples/WebApiApp/WebApiApp.csproj |
Retargets the Web API example to .NET 8. |
examples/ConsoleApp/ConsoleApp.csproj |
Retargets the console example to .NET 8. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Summary
Validation
dotnet build FeatBit.ServerSdk.sln -c Releasedotnet test FeatBit.ServerSdk.sln -c Release --no-build --no-restore --verbosity minimal(180 passed, 1 skipped)dotnet pack src/FeatBit.ServerSdk/FeatBit.ServerSdk.csproj -c Release --no-build --no-restoregit diff --checkSummary by CodeRabbit
New Features
Improvements
Greptile Summary
The PR upgrades the SDK, tests, and examples to .NET 8 while retaining the .NET Standard and .NET Framework targets.
Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Important Files Changed
Reviews (2): Last reviewed commit: "chore: point package project URL to Feat..." | Re-trigger Greptile