Skip to content

Sync Smith skill during config init#46

Merged
faustodavid merged 4 commits into
mainfrom
feature/skill-symlink-sync
Jun 2, 2026
Merged

Sync Smith skill during config init#46
faustodavid merged 4 commits into
mainfrom
feature/skill-symlink-sync

Conversation

@faustodavid
Copy link
Copy Markdown
Owner

Summary

  • Add a smith.skill sync helper that links ~/.agents/skills/smith to the bundled skill, preferring Homebrew's stable opt/smith path when available.
  • Run skill sync during smith config init and add smith skill sync / smith skill status for existing users.
  • Update the Homebrew helper to create a symlink instead of copying the skill, and tighten the formula test to assert that symlink.
  • Update README Homebrew instructions to use brew install faustodavid/tap/smith followed by smith config init, with a concise upgrade note.

Validation

  • uv run --extra dev pytest tests/unit/test_skill.py tests/contract/test_cli_contracts.py::test_handle_config_init_creates_empty_config_file tests/contract/test_cli_contracts.py::test_handle_config_init_rejects_existing_config_file tests/contract/test_cli_contracts.py::test_handle_skill_sync_reports_current_link tests/unit/test_config.py::test_load_config_rejects_reserved_top_level_remote_names tests/unit/test_onboarding.py::TestValidateRemoteName::test_reserved_name_rejected -q
  • uv run --extra dev ruff check src/smith/skill.py src/smith/cli/handlers.py src/smith/cli/parser.py src/smith/formatting.py tests/unit/test_skill.py tests/contract/test_cli_contracts.py tests/unit/test_config.py tests/unit/test_onboarding.py
  • temporary-path CLI smoke: smith config init, smith skill status, symlink verification
  • JSON smoke: smith config init --format json
  • make check
  • ruby -c Formula/smith.rb
  • brew style ./Formula/smith.rb
  • git diff --check
  • temp tap audits: brew audit --formula --strict and brew audit --formula --new

Release note

This updates source behavior. The public Homebrew install will get smith config init skill syncing after the next Smith release/tag and tap formula bump. The formula helper change is ready for that bump and still keeps smith-install-skill as a compatibility path.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bb054b9b2b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/smith/skill.py Outdated
@faustodavid
Copy link
Copy Markdown
Owner Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2d08222f47

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/smith/skill.py Outdated
Comment thread src/smith/config.py Outdated
Comment thread src/smith/cli/handlers.py Outdated
@faustodavid
Copy link
Copy Markdown
Owner Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9635cdc383

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/smith/config.py
@faustodavid faustodavid merged commit 340aac8 into main Jun 2, 2026
9 checks passed
@faustodavid faustodavid deleted the feature/skill-symlink-sync branch June 2, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant