prometheus: remove stale unix socket file when binding from ffi

[jkarneges]

When binding a unix socket, the specified file must not exist. We already have logic to handle this in NetListener::bind_config (i.e. delete stale file before binding), we just need to be using it. This PR refactors the prometheus_server_create FFI function to call bind_config.

[Copilot]

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Pull request overview

Refactors the Prometheus FFI server creation to reuse existing NetListener::bind_config logic so stale Unix socket files are removed before binding.

Changes:

• Replace custom FFI listen-address parsing with NetListenConfig + NetListener::bind_config.
• Add NetListenConfig::from_prometheus_port_str helper for parsing the Prometheus listen format (ipc://…, host:port, or port).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
src/core/prometheus.rs	Refactors FFI server creation to parse into NetListenConfig and bind via bind_config (stale unix socket cleanup).
src/core/config.rs	Adds a parsing helper to build NetListenConfig from the Prometheus port/address string format.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.